Move areaDetector plugins from child classes to parent classes #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #212 |
jmaruland
force-pushed
the
move-areaDetector-plugins-to-ndplugin-classes
branch
from
8f1f5b2
to
34c4abb
Compare
|
This PR got a bit behind of the current state of the main branch and there was a conflict with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue presented in #212 which looks to give more visibility to some nd_plugins.
In order to decide which plugins need to be moved up, the NDArrayBase template (https://github.com/areaDetector/ADCore/blob/master/ADApp/Db/NDArrayBase.template) was used. Plugins mentioned in this template were moved to the immediate parent class (NDArrayBase or NDPluginBase)